search

GLibSharp / GtkSharp

.Net bindings for gtk+3 and above
Other
30 stars 21 forks source link

Dockerize CI #24

Closed GusBricker closed 7 years ago

GusBricker commented 7 years ago

Switches CI over to use Debian 9 based Docker image, allowing us build against later version of GTK.

GusBricker commented 7 years ago

I think dbuild.sh should remain in the top folder as its meant to be a convenience script for people that download the project (thus it has nothing to do with CI). Also instead of having a CI folder, the build.sh script should instead be renamed to .ci_build.sh and remain in the top folder.

Side note as well, if you are going to request changes then generally wait for the other party to reply before you lodge another PR with the fixes you suggested, otherwise it kind of short circuits the discussion. :)

thiblahute commented 7 years ago

Yeah, sorry for the other PR, I just wanted to test my changes on top of your PR :-)