search

GLibSharp / GtkSharp

.Net bindings for gtk+3 and above
Other
27 stars 21 forks source link

Fix for memory leak issue #42 #43

Closed midmohan closed 4 years ago

sdroege commented 4 years ago

See my comment here: https://gitlab.freedesktop.org/gstreamer/gstreamer-sharp/merge_requests/16#note_412876

sdroege commented 4 years ago

Also https://github.com/GLibSharp/GtkSharp/pull/41 might be interesting for you too, without that you'd also get basically every element leaked.

https://github.com/GtkSharp/GtkSharp/ has a different "solution" to this (related to that other issue/PR you linked to over there), which is wrong from what I can see.

midmohan commented 4 years ago

Also please update the generated code now that it is checked out in tree please :-)

Are there more generated files that has the finalizerInfo class, my search dint returned any. Can you please let me know , which files you are referring to.

thiblahute commented 4 years ago

Are there more generated files that has the finalizerInfo class, my search dint returned any. Can you please let me know , which files you are referring to.

All the files in the various generated/ folder, I made substantial changes today and now generated files are being checked out in the source tree, the same way we do in in gstreamer-sharp.

thiblahute commented 4 years ago

As discussed in the gstreamer-sharp counter part of that PR, I think we should rather fix the main issue in the way GSource is wrapped and implement what is being described here

Do you think you could work on that?

midmohan commented 4 years ago

As discussed in the gstreamer-sharp counter part of that PR, I think we should rather fix the main issue in the way GSource is wrapped and implement what is being described here

Do you think you could work on that?

Let me take a stab at that.

midmohan commented 4 years ago

raised https://github.com/GLibSharp/GtkSharp/pull/45

thiblahute commented 4 years ago

Closing in favor of https://github.com/GLibSharp/GtkSharp/pull/45