search

GLibSharp / GtkSharp

.Net bindings for gtk+3 and above
Other
27 stars 21 forks source link

Trying a better fix for memory leak issue #42 #45

Closed midmohan closed 4 years ago

midmohan commented 4 years ago

I am not sure if these are sufficient , Let me know if these needs to be changed or more places needs to be handled, from my testing, I could see only the Timeoutproxy leaking(see attached screenshot in the issue).

In the fix , I am not sure though about using priority as 0, and the Add overload having priority is not used , rather replaced the existing _add to use add_full with priority 0. Please let me know if thats okay.

midmohan commented 4 years ago

@sdroege @thiblahute , Please let me know if this works , or any more changes are required

thiblahute commented 4 years ago

Looks all good to me, I wonder why it was done the way it was!

@sdroege Let's get it in?

midmohan commented 4 years ago

Now that this is in would it be possible to get a new Release of GStreamer-sharp nuget, build with these changes?