search

GLibSharp / GtkSharp

.Net bindings for gtk+3 and above
Other
27 stars 21 forks source link

Add a simple CI that builds the whole project #56

Closed ylatuya closed 3 years ago

thiblahute commented 3 years ago

Any idea why the checks is empty?

ylatuya commented 3 years ago

I have no idea, it's the first time I setup a CI pipeline using GitHub Actions, I will have to check the docs to see how it should work. What I can see is that Actions are run in my fork, but not here for example.

ylatuya commented 3 years ago

Fixed, it's done automatically with the event "pull_request" which was missing.

ylatuya commented 3 years ago

@thiblahute you should also enable "Run workflows from fork pull requests"

ylatuya commented 3 years ago

See https://github.com/ylatuya/GtkSharp/pull/1 for a reference

thiblahute commented 3 years ago

I set " Require approval for first-time contributors who are new to GitHub " and it didn't start the workflow, also I don't get why it is not even visible tbh, any idea?

ylatuya commented 3 years ago

I have no idea, it's probably related to the fact that it's the first time it's added and it's done from a fork. Can you try creating a PR yourself from the same branch in this repo?

thiblahute commented 3 years ago

Closing as https://github.com/GLibSharp/GtkSharp/pull/57 has been merged instead.