Closed ghost closed 9 years ago
the image edit button will allow you to edit the text content of a ORC scan both the image and the text are visible form the editor
Thanks for that clue. Yes, that satisfies the part about email body editing after OCR.
Still would like the facility to include the image as part of the email. Simply including it as an attachment would be fine.
Further to this, have the email body available to edit irrespective of whether the result is OCR or not ? As OCR might take longer than populating what is needed manually.
Figured out some of the markup to provide some (initial) suggested modifications, refer http://postimg.org/gallery/1hzvhqi3o/
Add a new flag, default to be Image Only. When OCR Only selected, disable the File Type selection. Remove TXT from the File Type selection.
I see on the Edit page, the markup is separate from that on the main page.
I wanted to provide some diffs for review, but I am not comfortable enough with the code base to do that.
im not sure when/if i will get to/do this
this will not be a easy change, not as confusing as the css rotate+transition effect (very complex math))
it would not be necessary to redo that part of the ui to do that (would be a pita to handle that in the back-end with how integrated i have everything, i don't even want to imagine how many bugs that would make)
it is merely a option to provide when doing a email of a .txt file
i think the modification would be done to the email section, not the scanning area, assuming a preview quality image is good enough, if not it just means not deleting the image used to make the txt file and saving it in the scans folder under a appropriate file time, maybe .txt.raw (png format file)
that part is near the end of index.php
the ui part for the email is mostly in res/main,js
making the body of the email editable should not be that hard, should only involve main.js and email.php @ line 56
I have done a fork and pull request for the email body text, however I am not sure how to make the text box larger. Using textarea did not work.
I have done a few scans/emails to myself and the body contains the text that the email dialogue was populated with.
that is probably some CSS i will take care of that
auctually that is not the issue
textarea is not a type it is a tag name
you mean this
<textarea name="body"></textarea>
i'm not sure i like the placement for the message http://i.imgur.com/uDq2qEW.png maybe below the scanned image would be better?
i think i like at the top more http://i.imgur.com/1mR1nV5.png
see commit fed83c1bfa
Thanks, that works fine.
does that cover everything you asked for? if so you can close this issue
Thanks, this will be fine.
This would be very useful when searching in email for a document, to have both the OCR'd text and the image in the same email.
As the text could be quite long, I suggest a configurable limit on the number of characters, and using providing a modal pop up launched from the email dialogue.