Open UmbralReaper opened 3 years ago
please squash and merge I don't want to see this.
please squash and merge I don't want to see this.
Sure!
@TheGoatGod Travis CI appears to be failing.
@TheGoatGod Why would you merge this? I explicitly stated that it wouldn't have any benefit!
We could merge this now, but it would prevent doing any of the above (and wouldn't have any benefit).
Even putting that aside, did you test it? Make sure that it worked properly? I certaintly haven't run any tests beyond a general smell check.
EDIT: cough. Seems that I misread the merge. I apologise for my mistake.
please squash and merge I don't want to see this.
This goes for you too. Let’s both endeavour to keep the commit history clean!
https://github.com/GMC-Modding-Team/Community-Mod-Compilation-redux/pulls please move here, and i will be doing so in future
Summary Add i18n capabilities to the mod compilation.
Content Add a script that extracts all the name and description strings from the JSON and a workflow that automates it.
.md
files.name
anddescription
.We could merge this now, but it would prevent doing any of the above (and wouldn't have any benefit).
Additional context Even if nobody uses it, I still feel that we should give the option to translate mods.