GMC-Modding-Team / Community-Mod-Compilation-Deprecated

All the mods & mainline mods reactivated (Community Mod Compilation) originally started and still maintained by TheGoatgod
https://discourse.cataclysmdda.org/t/all-the-mods-mainline-mods-reactivated-goats-mod-compilation-v0-0-2/22725
Apache License 2.0
17 stars 11 forks source link

Localisation #282

Open UmbralReaper opened 3 years ago

UmbralReaper commented 3 years ago

Summary Add i18n capabilities to the mod compilation.

Content Add a script that extracts all the name and description strings from the JSON and a workflow that automates it.

We could merge this now, but it would prevent doing any of the above (and wouldn't have any benefit).

Additional context Even if nobody uses it, I still feel that we should give the option to translate mods.

TheGoatGod commented 3 years ago

image

TheGoatGod commented 3 years ago

please squash and merge I don't want to see this. image

UmbralReaper commented 3 years ago

please squash and merge I don't want to see this.

Sure!

UmbralReaper commented 3 years ago

@TheGoatGod Travis CI appears to be failing.

UmbralReaper commented 3 years ago

@TheGoatGod Why would you merge this? I explicitly stated that it wouldn't have any benefit!

We could merge this now, but it would prevent doing any of the above (and wouldn't have any benefit).

Even putting that aside, did you test it? Make sure that it worked properly? I certaintly haven't run any tests beyond a general smell check.

EDIT: cough. Seems that I misread the merge. I apologise for my mistake.

UmbralReaper commented 3 years ago

please squash and merge I don't want to see this.

This goes for you too. Let’s both endeavour to keep the commit history clean! 83DCCF6A-88A8-44BE-95F8-D0F506B3B26A

TheGoatGod commented 3 years ago

https://github.com/GMC-Modding-Team/Community-Mod-Compilation-redux/pulls please move here, and i will be doing so in future