UI delay and cosmetics permissions

lightclaw commented 6 years ago

Description of bug

There are somewhat-major bugs in the UI I've found. A week (or a bit more ago) I've got 2 drops of Murphy cosmetic and I was able to sell them. That was before I've bought bronze VIP. Now I cant sell Murphy, and I attempt to, I will get an error message "You're not allowed to sell this item!". Trying it about 3 times after that will cause major shop UI delay (about 10 seconds or more) at the Store tab. I also know that JR Mods have the same issue.

What I expected to happen

Get 30 tokens off Murphy and live happily.

What instead happened

"You're not allowed to sell this item!" and a free delay that renders Store UI useless.

Steps to reproduce

Be Bronze VIP/JR Mod
Get Murphy from the gift drop ?
Get denied, break your Mann co. store

Providing a demo is not a necessity here since demo files dont record in-game menus.

Extra info (evidence, logs, etc)

Just in case

KeyValues Error: RecursiveLoadFromBuffer:  got EOF instead of keyname in file models/seat_m/seat_01_phy.mdl
mdlkeyvalue, (*prop_data*), 
KeyValues Error: RecursiveLoadFromBuffer:  got EOF instead of keyname in file models/seat_m/seat_01_phy.mdl
mdlkeyvalue, (*prop_data*), 
*DEAD* [Bronze] yuukarin: later
*DEAD* [Bronze] yuukarin: 5 min
You're not allowed to sell this item!
Dont see a playermodel/accessory you like on the store? Request it on the forums at https://devinity.org
You're not allowed to sell this item!
Holstered Murphy!
You're not allowed to sell this item!
Equipped Murphy!

EDIT: As of 06.08.2018 the lag issue might be related to poor server perfomance tho im not sure. I had this issue at 10:00 pm CEST.

Donkie commented 6 years ago

If it's correctly configured, seasonal item drops shouldn't be sellable until the season is over since it leads to abuse

lightclaw commented 6 years ago

Then it is broken for normal users since I was able to sell about 2-3 Murphys. Also I'm not sure why, but I'm having major lag with anything on Q and TAB. Speedtest didnt show anything abnormal and no packet loss.

CounterCraftz commented 6 years ago

I've disabled selling since that was the case. I think the framerate naturally hangs whenever you open a menu especially with html pages

Get Outlook for Androidhttps://aka.ms/ghei36

From: lightclaw notifications@github.com Sent: Monday, August 6, 2018 4:17:39 PM To: GMDevinity/FloodIssues Cc: Subscribed Subject: Re: [GMDevinity/FloodIssues] UI delay and cosmetics permissions (#510)

Then it is broken for normal users since I was able to sell about 2-3 Murphys. Also I'm not sure why, but I'm having major lag with anything on Q and TAB. Speedtest didnt show anything abnormal and no packet loss.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/GMDevinity/FloodIssues/issues/510#issuecomment-410839796, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKgwIPHpS68qLuloK1nW9PlJI0NCAF94ks5uOKRjgaJpZM4Vw_i0.

lightclaw commented 6 years ago

Its not about the frame rate, I mean you cant sell/buy cosmetics at an instant, theres a massive delay between my actions. I also forgot to mention that not every drop is blocked from selling. For an example, I'm able to sell Straw Hat.

Donkie commented 6 years ago

The database has been under more and more stress last months/years and I'm looking into better solutions, that's the reason for the slow actions.

CounterCraftz commented 6 years ago

I'll disable selling on those items until the issue has been fixed or after the event is over

GMDevinity / FloodIssues