GMELab / MonsterLM

A method to estimate the proportion of variance explained by heritability and gene-by-environment interactions, in a fast, accurate, efficient, and unbiased manner on biobank-scale datasets (N>300,000).
GNU General Public License v3.0
1 stars 0 forks source link

discrete/dichotomous Es #2

Open Zhengtong-Liu opened 7 months ago

Zhengtong-Liu commented 7 months ago

We are interested in your method MonsterLM to estimate GxE heritability. It stands out in the field for its innovative approach and its consideration of noise heterogeneity, demonstrating scalability to large-scale biobank datasets. However, we ran into some problems when using the code shared in the GitHub repository. Specifically, the MonsterLM paper suggests applying separate transformations for dichotomous exposures (E) and outcomes (Y) prior to estimating GxE heritability. However, the code available on Github appears to be applicable only to the setting with continuous E and Y variables. We hypothesize that this was the reason for some of the high false positive rates in some of our simulations with discrete E variables. To address this issue, we made four specific modifications to the CPU implementation (outlined below) to incorporate the handling of discrete/dichotomous Es, as described in the paper. Our simulations indicate that these adjustments led to significantly lower false positives. Could you please review the changes we made for accuracy?

Thanks for your consideration.

Screen Shot 2024-04-02 at 1 31 26 PM Screen Shot 2024-04-02 at 1 31 53 PM Screen Shot 2024-04-02 at 1 32 05 PM Screen Shot 2024-04-02 at 1 32 15 PM

discipim commented 7 months ago

Hi Zhengtong,

This is an excellent user-friendly update to enable the specific transformations required for a continuous vs dichotomous E. The new input and suggested edits here have been updated to the CPULS script.