search

GMLC-1-4-2 / battery_interface

Implemenation of Device Models and their Battery Equivalent Interface
MIT License
5 stars 0 forks source link

HVAC and Refridge Pull Request #110

Closed Hayden-Reeve closed 5 years ago

Hayden-Reeve commented 5 years ago

@hlngo (cc: @ORNLJD , @DavidWiniarski-pnnl , @emayhorn )

Here is a second attempt to pull HVAC and Refridge (this time with SourceTree). This replaces #107 and #77 and should reflect all of the changes in #77 as of this morning.

Hayden-Reeve commented 5 years ago

@ORNLJD (@DavidWiniarski-pnnl )

Refridge seemed to do a good job of providing up and down flexibility with regulation. Looks like the fleet scaling factor will need to be tuned though.

20190513_August_2secnormsignals_Dynamic_RFFleet

hlngo commented 5 years ago

@Hayden-Reeve There are some conflicts. Did you update your local repos before making this pull request?

Hayden-Reeve commented 5 years ago

@hlngo ,

Yes, this is based on a clean clone and #77 . I assume that this has inherited conflicts from #77 . The HVAC code in the master is so old I recommend adopting the code in this PR completely. We can discuss more with @ORNLJD during the meeting tomorrow.

ORNLJD commented 5 years ago

@ORNLJD (@DavidWiniarski-pnnl )

Refridge seemed to do a good job of providing up and down flexibility with regulation. Looks like the fleet scaling factor will need to be tuned though.

20190513_August_2secnormsignals_Dynamic_RFFleet

@Hayden-Reeve

Agree, we may need to tune the scaling factor. It seems the fleet is unable to ramp up/down that deep. For the figure, should the unit in your Y-axis be kW instead of MW?

Hayden-Reeve commented 5 years ago

@hlngo , I addressed the conflicts and then recommitted the case_model and build_model files as the changes were not getting reflected correctly. I think this is ready to merge (and I can then retest to make sure everything is correct).