gridPULSE submission

[afernandezcanosa]

@jmaguire1 @ORNLJD (CC. @Hayden-Reeve @hlngo) We need to submit the Battery-Equivalent model to the GMLC 1.2.3. gridPULSE repository. I was wondering if you have finished incorporating the latest updates on your code and merged into the master repo. Please, let me know if you are done so that I can submit the code.

Thanks!

[afernandezcanosa]

@jmaguire1 @ORNLJD @Hayden-Reeve @hlngo Have all the critical pull requests been merged into the master code? Please, let me know so that we can proceed with the submission to the GMLC 1.2.3. library.

If not, I think we can still submit the code to the GMLC 1.2.3. repo and update the code later once your PRs have been merged.

Thanks.

[jmaguire1]

@afernandezcanosa @Hayden-Reeve @hlngo Thanks for the reminder, I had a couple of final changes to the water heater fleet, water heater model, and config file that ought to be merged. The only relevant files that changed are in this commit: https://github.com/jmaguire1/battery_interface/commit/1a1f81e87521dcd172d053174ffd1235c66449db

@hlngo Should I make a new pull request for this, or is there an easier way to merge just these three files? If I recall there were several conflicts that I was unable to edit myself last time I did a pull request off my fork.

[afernandezcanosa]

@afernandezcanosa @Hayden-Reeve @hlngo Thanks for the reminder, I had a couple of final changes to the water heater fleet, water heater model, and config file that ought to be merged. The only relevant files that changed are in this commit: jmaguire1@1a1f81e

@hlngo Should I make a new pull request for this, or is there an easier way to merge just these three files? If I recall there were several conflicts that I was unable to edit myself last time I did a pull request off my fork.

@jmaguire1 Perfect. I will wait to submit the code to gridPULSE until the merge is finished. Thanks.

[jmaguire1]

@afernandezcanosa Yes, no worries, thanks again for reminding me and hosting all of this

[afernandezcanosa]

@Hayden-Reeve @hlngo (CC. @raselmahmud02) I am not sure whether or not it is the best idea to submit the model to the gridPULSE library before releasing the open-source beta of the code. As there are certain fields regarding the availability of the code (proprietary or open-source) and links to the GitHub repo, maybe we should wait until the release of the code.

What do you think? What is the status of the release of the code? If I recall correctly, the ownership of the GitHub repo has changed from PNNL to NREL.

[raselmahmud02]

@Hayden-Reeve @hlngo @afernandezcanosa Just fyi: We were not able to maintain the github subscription as there was a problem with paying recurring monthly fee (NREL policy makes it much difficult) and GitHub is not a NREL approved repository website.

[afernandezcanosa]

@Hayden-Reeve @hlngo @afernandezcanosa Just fyi: We were not able to maintain the github subscription as there was a problem with paying recurring monthly fee (NREL policy makes it much difficult) and GitHub is not a NREL approved repository website.

Thanks for the info, @raselmahmud02. Should we then proceed to make the repo public, @Hayden-Reeve, @hlngo?

[Hayden-Reeve]

@afernandezcanosa , let me check if approval is needed for making it public. I think we can move ahead to putting it on GridPulse as at least proprietary for now and then changing to open in the future

[afernandezcanosa]

@Hayden-Reeve Excellent. Let me know if the repo can be made public easily. The problem with the gridPULSE submission is that it requires a link to the GitHub repo if there exists one, that's why I prefer to submit it once the repo is made public.

Also, I am not sure if we can make the gridPULSE submission as if the project is proprietary and then change it to open-source. Despite this, I can proceed with the submission as proprietary if you think that making the repo public is going to take so much time.

Thank you.

[hlngo]

@afernandezcanosa It's easy to make it public. Just need approval.

[afernandezcanosa]

@hlngo Thanks - In this case, I will wait until the library is made public to submit it to gridPULSE.

[Hayden-Reeve]

@afernandezcanosa , @raselmahmud02 @hlngo

I was able to confirm with Rob that the library has approval from all the labs to be public. @hlngo (cc @raselmahmud02 ) do we know the steps to make the GitHub repository open? My understanding is that once that is done @afernandezcanosa can then link GridPulse to that version.

[afernandezcanosa]

@Hayden-Reeve Thanks for taking care of this. To make the repo public, we just need to follow these steps: https://help.github.com/en/articles/setting-repository-visibility

Probably @hlngo or @raselmahmud02 (as you changed the ownership of the repo) are the only ones who can make the repo public, I am not sure... Once this is done, I will link the public GitHub to the gridPULSE submission.

Thanks!

[hlngo]

I have been removed from admin role so now I can't do it anymore. Whoever has the admin right will have to do it.

[raselmahmud02]

@hlngo : your admin role has been restored. Could you please check the repository to make it public?

[Hayden-Reeve]

@afernandezcanosa (@hlngo , @raselmahmud02 ),

I have made the repository public. Please go ahead and link/contribute this to GridPulse.

Thanks Hayden

[afernandezcanosa]

Thanks, @Hayden-Reeve

The model is now available on gridPULSE under this link: https://openlibrary.gridpulse.org/openlibrary/models/39b30aac

I need to reassign the admins and authors of the model as most of them disappear for an unknown reason. Also, as I opened the model with my ANL account, I cannot change the affiliation of the model.

I'll let you know all as soon as I update this.

Thanks.

[afernandezcanosa]

The authors and admins should have been updated now. Let me know if you find something wrong or if I have missed someone. Thanks.