search

GMLC-1-4-2 / battery_interface

Implemenation of Device Models and their Battery Equivalent Interface
MIT License
5 stars 0 forks source link

energy market #44

Closed TomEdmunds closed 5 years ago

TomEdmunds commented 5 years ago

Wholesale energy market service code and example I/O

hlngo commented 5 years ago

@emayhorn Can you review this PR?

emayhorn commented 5 years ago

@emayhorn Can you review this PR? Yes. will do

emayhorn commented 5 years ago

@TomEdmunds I reviewed the energy market code. 'DispatchTable 10-19-18' runs. However, it does not follow the same template as the other service models submitted that will allow it to be integrated and run with different device fleets. At a minimum, each service that has been successfully integrated with device models, defines a service class and a request_loop method that allows requests and responses to be sent and received from a fleet. Can you modify your code to follow this format, so that we can properly integrate energy market code with the master code? Please see the reserve_service.py, reg_service.py, or artificial_inertia_service.py as well as the test.py submitted for each of these services as an example.

hlngo commented 5 years ago

Closed due to https://github.com/GMLC-1-4-2/battery_interface/pull/83