search

GMLC-1-4-2 / battery_interface

Implemenation of Device Models and their Battery Equivalent Interface
MIT License
5 stars 0 forks source link

Assigned Regulation MW deprecated #51

Closed afernandezcanosa closed 5 years ago

afernandezcanosa commented 5 years ago

@hlngo According to our last integration meeting, this method will be no longer used for scaling and should be deleted (It was only used for the regulation service). https://github.com/GMLC-1-4-2/battery_interface/blob/a286babbc4423f4b2a072c805b6c4a516ce11ec8/src/fleet_interface.py#L61-L62

Instead, we are going to use this one for all the services (including the regulation service): https://github.com/GMLC-1-4-2/battery_interface/blob/a286babbc4423f4b2a072c805b6c4a516ce11ec8/src/fleet_interface.py#L64-L65

Thanks!

hlngo commented 5 years ago

@afernandezcanosa @emayhorn Does every device need to override the assigned_service_kW()?

afernandezcanosa commented 5 years ago

@hlngo Yes, all of the devices need the assigned_service_kW() method.

hlngo commented 5 years ago

@afernandezcanosa I am closing this issue due to duplicate with the scaling issue created by Ebony