GMLC-1-4-2 / battery_interface

Implemenation of Device Models and their Battery Equivalent Interface
MIT License
5 stars 0 forks source link

peak management service ready for integration #86

Closed emayhorn closed 5 years ago

emayhorn commented 5 years ago

Code updates include the following:

hlngo commented 5 years ago

@emayhorn question regarding your last bullet point: we have multiple fleets and services, how do a service know whether a fleet needs to be run with timestep greater or less than 1 hour?

emayhorn commented 5 years ago

@emayhorn question regarding your last bullet point: we have multiple fleets and services, how do a service know whether a fleet needs to be run with timestep greater or less than 1 hour?

A service should not be run with a fleet that requires a greater timestep than the service. I defined the variable fleet_sim_step so that a user can specify the sim_step (the timestep to be passed to the process_request method). If the fleet sim_step is less than 1 hour, the service should send the same hourly P_req value at each sim_step within an hour. We may need to update the code to return an error message warning that the code cannot be run if fleet_sim_step > service timestep (1 hour in this case).

emayhorn commented 5 years ago

@hlngo (cc @Hayden-Reeve ) I see that you have merged the pull requests with the master. We were hoping you could also integrate the peak management, distribution voltage and energy market service codes just as you've done in the past for regulation, spinning reserve and AI. Are you already working on the integration? Do you need help with this?

hlngo commented 5 years ago

@emayhorn Done. Please review.