search

GMLC-TDC / HELICS-Examples

Examples for using HELICS with a variety of the supported programming languages
BSD 3-Clause "New" or "Revised" License
21 stars 19 forks source link

Advanced Orchestration example references files that don't exist in the same folder #58

Closed nightlark closed 1 year ago

nightlark commented 2 years ago

There is no folder for the advanced orchestration example that contains Battery.py, Charger.py, and make_samples.py -- based on the code in https://github.com/GMLC-TDC/HELICS-Examples/blob/main/user_guide_examples/advanced/advanced_orchestration/simple/ev_uq_example.yaml#L15 which expects all 3 of these files to be in the same folder ($(SPECROOT)). My best guess is that line 15 should read $(SPECROOT)/simple/make_samples_merlin.py.

trevorhardy commented 2 years ago

@allisonmcampbell, can you get this sorted out today (Monday, 29th)? We're trying to get a v3.1 release out and would like to have all our ducks in a row.

allisonmcampbell commented 2 years ago

yes, seeing this now. I'll report back when it's done.

allisonmcampbell commented 2 years ago

Yes, @nightlark , your proposed solution makes sense:

line 15 should read

 $(SPECROOT)/simple/make_samples_merlin.py
trevorhardy commented 2 years ago

@allisonmcampbell, is this resolved?