search

GMLC-TDC / HELICS

Hierarchical Engine for Large-scale Infrastructure Co-Simulation (HELICS)
https://docs.helics.org/en/latest/
BSD 3-Clause "New" or "Revised" License
127 stars 41 forks source link

addLoadLibrary.cmake writes unsuitable library name #212

Closed afisher1 closed 6 years ago

afisher1 commented 6 years ago

In swig/java/addLoadLibrary.cmake the library that gets written inside of the System.loadLibrary() function when building the java bindings is "libJNIhelics". System.loadLibrary("x") will attempt to look for libx.dll/so/dylib so when trying to run a java federate using the helics.jar the System.loadLibrary("libJNIhelics") fails. Instead of "libJNIhelics" it needs to be "JNIhelics". Until this is fixed we can't use the jar file. Current work around is to edit the file and create the jar manually.

phlptp commented 6 years ago

is this still doing this after the merge from #210? that was supposed to address this issue

afisher1 commented 6 years ago

whoops! looks like this was addressed in 210 I'll double check to confirm, sorry. Working from pull from yesterday.

afisher1 commented 6 years ago

Yep 210 fixed this! Closing issue