search

GMLC-TDC / HELICS

Hierarchical Engine for Large-scale Infrastructure Co-Simulation (HELICS)
https://docs.helics.org/en/latest/
BSD 3-Clause "New" or "Revised" License
127 stars 40 forks source link

Documentation: EV example load oddly scaled #2666

Open bpalmintier opened 3 months ago

bpalmintier commented 3 months ago

Describe the bug In the documentation, the multi-port EV "advanced example" has unreasonable peak values, >20MW for 5 EVs, even

What is the expected behavior? Consider that Tesla DCFC chargers are often around 100-200kW and the faster side of EV car max charge rates is ~300kW then even if all 5 ports were at max the peak would be around 1.5MW (about 10x less). Moreover such charging sessions also are simulated to last multiple days, which would not be common with anything close to DCFC. It might be relevant for Level1, but then the charge rates are around 1.5kW/charger. Certainly higher charge rates might be seen with M/HDV, but this doesn't seem to the the case in the description

To Reproduce Review the output figures such as at https://docs.helics.org/en/latest/user-guide/examples/advanced_examples/advanced_brokers_multicomputer.html

Environment (please complete the following information):

Additional context and information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

Generally love these examples, it would also help to somewhat increase the domain story of what is going on. In this case it is unclear how the batteries loose charge. Are they being driven? V2G, etc. And also why they seem to almost always be connected for over a week (168hr) which is unexpected since even at Level-1, folks would likely be charging only when at home and have extended times away. Even more so for DCFC where sessions might only last 20min and would fill up enough for a week or more of around town driving.

trevorhardy commented 2 months ago

I recommend moving this to the HELICS-Examples repo.

Can you clarify why you consider this a "bug"? Is it the lack of realism?

bpalmintier commented 2 months ago

Yes the "bug" (agree awkward but didn't seem to fit other categories, perhaps we need a documentation update template?) is that the data is unrealistic enough to potentially undermine HELICS credibility. For reference, even with @.*** (which is on the high side) 5 EV cars would still only peak around 1MW if all simultaneously at max (unlikely) and that would only be for say 20min. For Level-2 that might be around 10kW/plug which would mean 50kW and then might last 5-10hrs, but still not for many days. In contrast the current results peak >20MW (20x too high) and never dip below ~3MW for a full week (60x too high, and much too long).

I had included here since this was the repo for documentation, if moving to the examples repo, maybe we need a linked one here to update the docs once fixed?

Here is the figure in question: [cid:2d9e5da3-d402-43af-a85a-1a46357a2c98]

From: Trevor Hardy @.> Sent: Monday, August 12, 2024 9:04 AM To: GMLC-TDC/HELICS @.> Cc: Bryan Palmintier @.>; Author @.> Subject: Re: [GMLC-TDC/HELICS] Documentation: EV example load oddly scaled (Issue #2666)

CAUTION: This email originated from outside of NREL. Do not click links or open attachments unless you recognize the sender and know the content is safe.

I recommend moving this to the HELICS-Examples repo.

Can you clarify why you consider this a "bug"? Is it the lack of realism?

— Reply to this email directly, view it on GitHubhttps://github.com/GMLC-TDC/HELICS/issues/2666#issuecomment-2284227609, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAB43OG4UJCO4WQQZYWHIGLZRDFH5AVCNFSM6AAAAABMAUMTG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBUGIZDONRQHE. You are receiving this because you authored the thread.Message ID: @.***>