GMNGjoy / FS22_SpawnPalletsStacked

Farming Simulator 22 MOD that will spawn 2x-10x more pallets in every spawn point.
Creative Commons Zero v1.0 Universal
4 stars 0 forks source link

Not works with mod outside default of the game... #2

Open FirenzeIT opened 6 months ago

FirenzeIT commented 6 months ago

Hello, this mod it's very useful and realistic, but not works with other mod outside of the default game (example productions/serres of Rvamp, or Greenhouses With Pallets and others productions/factories, only on default's mod) :-( It's possible to fix them for all general?? Or it's impossible?? at least for the modhub's greenhouses and factories, it would be the top

GMNGjoy commented 6 months ago

Thank you for your report / question!

The overall intention of the Spawn Pallets Stacked mod is specifically to work with any building or mod that has pallet spawn locations, and with any kind/size of pallet. From all of my testing, I have not found any single mod on Modhub (or otherwise) that this mod does not work for, within the guidelines of the mod.

I'm curious about your report - as the statement is made in a very generalized way stating that the Spawn Pallets Stacked mod does not work for a large series of mods/types of mods - but as I just spoke about, it's designed to do just that. Have you tried using the mod and are experiencing issues? If you have any specific mods that you have found that the spawning does not work with, please let me know and I'll look into it!

The screenshots here and on ModHub show primarily (but not only) base game buildings, due to the audience of the release - since it's not possible without editing/creating copies of base game productions to get those productions with stacked pallets - thereby showing that it works as intended. This is one of the major selling points of the mod itself.

The few cases where the Spawn Pallets Stacked mod will "prevent failure" and not stack pallets or not double-up are as follows:

FirenzeIT commented 6 months ago

Hello, i tried all way for doing something works with other mods, but i break the mod and i redownloaded... I add below 3 screenshots from 3 different greenhouses, which i write not works (1 works because it's a default base game greenhouse)..

Empty_Pallets_Prod_Revamp_Ed Greenhouse_default_base_game Greenhouses_with_Pallets

GMNGjoy commented 6 months ago

Thank you for those screenshots!

What would greatly help is if you could possibly share the name of those two greenhouse mods and / or the ModHub link where you got them from... The screenshots appear to be in another language other than english, and it's hard to tell from the screenshots which mod those greenhouses are from.

As far as the mod working or not - if you look at the screenshots where the pallets are not spawning properly, you can tell that with the revamp one that the mod is attempting to do it’s job (the line of pallets is moved slightly to try to get two rows in, for the doubleUp feature) but i suspect it was unable to fit a second row so the safety checks caused the spawing to exit without adding the stacking layers. that’s expected for most greenhouses as they have a very shallow spawn area. I suspect you'd have a line in your log where that failure is caught and reported. (if you add a configuration of <debugFull>true</debugFull> in the settings section it will give you a higher level of debug output)

In the code for the mod, there's a section that attempts to never "double up" for any item of type="greeenhouse" - in this case, suspect that the mods that you're demoing are not listed as a "greenhouse" somehow, and the logic is falling over. This is not something that I expected, but is something I can look into making an update to properly accommodate.

        -- don't doubleUp greenhouses
        if tostring(productionItem.typeName) == "greenhouse" then
            adjustment.shouldDoubleUp = false
        end

But, you can easily add a quick configuration line to your SpawnPalletsStacked.xml file in your modSettings folder right now that would look something like the following, which should fix the problem by setting the shouldDoubleUp feature to false

        <adjustment
            filename="FS22_YourGreenHouseModName/largeGreenhouse.xml"
            shouldDoubleUp="false" 
        />

If you send me the name / url of the mods in question, I'll be happy to test and give you a working adjustment to get you on your way!

FirenzeIT commented 6 months ago

Hi, i just tried modify that but i broken mod and need to redownloaded, however i add a screenshots below with there link site each... (both not stacked, but with default base greenhouse, it's stacked without any problems)...

Greenhouses with Pallets: 1248130_20240314013734_1 https://www.farming-simulator.com/mod.php?lang=en&country=it&mod_id=238185&title=fs2022

ProductionRevamp Productions (greenhouses it's included): 1248130_20240314013421_1 https://www.farming-simulator.com/mod.php?lang=en&country=it&mod_id=243667&title=fs2022

Also with this others greenhouse:

https://www.farming-simulator.com/mod.php?lang=en&country=it&mod_id=250574&title=fs2022

https://www.farming-simulator.com/mod.php?lang=en&country=it&mod_id=252317&title=fs2022