search

GMOD / Apollo

Genome annotation editor with a Java Server backend and a Javascript client that runs in a web browser as a JBrowse plugin.
http://genomearchitect.readthedocs.io/
Other
124 stars 85 forks source link

moving jbrowse "boundary" begins to halt #1115

Closed nathandunn closed 8 years ago

nathandunn commented 8 years ago

Moving side-bar around begins to lag badly.

This is new with 1.12.2 / 2.0.3 . . . I think either 1.12.1 or 2.0.2 may not have this error.

nathandunn commented 8 years ago
screen shot 2016-06-08 at 2 36 37 pm
nathandunn commented 8 years ago

Confirmed that this happens locally as well.

nathandunn commented 8 years ago

Tested in embedded jbrowse mode and did not get errors (in master).

nathandunn commented 8 years ago

Have this same issue with 1.11.6.

nathandunn commented 8 years ago

https://github.com/GMOD/Apollo/commit/afe39d282fc8aad31fd815c4c895174df480ad1d seems to be okay.

Should move up from here:

https://github.com/GMOD/Apollo/commits/master?page=2

nathandunn commented 8 years ago

working: https://github.com/GMOD/Apollo/commit/1bb53a792470024372c25de030f6447c0ccd1140

nathandunn commented 8 years ago

working: https://github.com/GMOD/Apollo/commit/e75ccadb913e3ae8f1a3ba867c5f7d17f98fd63e

nathandunn commented 8 years ago

working: https://github.com/GMOD/Apollo/commit/b5badcc04457ffe2ec812dd9056254b28200b0e3

jbrowse error appears when switching organisms, but not on initial load

nathandunn commented 8 years ago

seems to work: https://github.com/GMOD/Apollo/commit/bc53a52f5a45ab21db4d0cfe60c1750e108d4448 . . updated bootstrap plugin from 3.3.4 to 3.3.5

Worth pointing out this bug:

screen shot 2016-06-09 at 4 57 17 am screen shot 2016-06-09 at 4 57 10 am
nathandunn commented 8 years ago

works: https://github.com/GMOD/Apollo/commit/be1bde324beaf6d592881735ac239dd1d8c629c0

nathandunn commented 8 years ago

works: https://github.com/GMOD/Apollo/commit/bc53a52f5a45ab21db4d0cfe60c1750e108d4448

nathandunn commented 8 years ago

Breaks: https://github.com/GMOD/Apollo/commit/4657d7f4237bc56e52e3f5f5460a89d7107229a9

This change fixes some downstream javascript (except the help one).

nathandunn commented 8 years ago

Issues, 1 - defined in HTML or template or 2 - not destroyed properly (most likely since we only get this once)

https://www.sitepen.com/blog/2013/10/23/dojo-faq-why-am-i-getting-error-tried-to-register-widget-with-idxxx-but-that-id-is-already-registered/

nathandunn commented 8 years ago

http://stackoverflow.com/a/15361223/1739366

Probably easiest to check and re-assign.

nathandunn commented 8 years ago

I think we can safely remove this code:

It is all from this commit:

https://github.com/GMOD/Apollo/commit/b8964c1bc6553bd7c3811f1f3efcfa750d055e20

@GreggHelt2 Do you remember what this was to fix (zooming, etc. works well without it seems), in case I missed something during testing. I think that JBrowse + Dojo + Chrome upgrades may already be taking care of this.

monicacecilia commented 8 years ago

Yep. That's solved. Boundary is sliding without hiccup.

The description in https://github.com/GMOD/Apollo/commit/b8964c1bc6553bd7c3811f1f3efcfa750d055e20 refers to some errors in zooming in and out of base level. I have not come across this error again (bases are displayed correctly despite zoom level and with different settings (e.g. colored CDS, Dark theme, etc). I agree with you. Chrome finally caught up and we can dispense with that code.

Gets a 💃 !