GMOD / Apollo

Genome annotation editor with a Java Server backend and a Javascript client that runs in a web browser as a JBrowse plugin.
http://genomearchitect.readthedocs.io/
Other
128 stars 85 forks source link

enable oauth login to enable drupal authentication #139

Closed nathandunn closed 7 years ago

nathandunn commented 9 years ago

related to pull request #117 . . .

nathandunn commented 9 years ago

@cmdcolin Here is the original one. The oauth should be in there. Just isn't doing anything.

cmdcolin commented 9 years ago

Thanks for pointing me to it. I'll see what I can do.

cmdcolin commented 9 years ago

The OAuth api is fairly complex and I don't have time to review all the intricacies right now. I almost got it to authenticate using the existing code, but it I had to change lines 222-225 to a get request instead of a post and then i still didn't end up with an ID token after that.

So, deferred for now.

I will probably review this later when time is available http://oauthbible.com

For now I'll just remove it from the change log

nathandunn commented 9 years ago

I think that is a good call. I moved it.

vivekkrish commented 9 years ago

Just wanted to chime in on this.

Have you all come across jso (OAuth 2.0 Client with Javascript, https://github.com/andreassolberg/jso)? It implements the complete OAuth2.0 implicit flow, and is AMD-loading compatible.

Just with about 5-10 lines of javascript (see the Getting Started section), it is possible to make an client side app like JBrowse support an OAuth2.0 based login flow.

And, according to their documentation, a new version of jso is available for testing, which supports authentication with OpenID as well, see: http://oauth.no/jso/

Hope this helps!

nathandunn commented 9 years ago

Thanks . . . we might be able to use this. I've heard that figuring out OAuth flavors can be interesting.

vivekkrish commented 9 years ago

You're welcome! I was alerted to the presence of this module by one of our collaborators at UT Austin.

We've explored the possible integration of this into our applications to utilize our own OAuth2 login flow (within the Araport project, https://www.araport.org), giving such apps access to an Araport token which could be utilized to make calls to authenticated Araport APIs (https://www.araport.org/api-explorer/).

nathandunn commented 8 years ago

@laceysanderson Suggested that drupal / tripal might get an automatic oauth module and we would connect to that.

nathandunn commented 7 years ago

Dupe of #938