GMOD / Apollo

Genome annotation editor with a Java Server backend and a Javascript client that runs in a web browser as a JBrowse plugin.
http://genomearchitect.readthedocs.io/
Other
128 stars 85 forks source link

When logged clicking on JBrowse will not go to the Annotator Panel #1395

Closed childers closed 7 years ago

childers commented 7 years ago

I currently see a navigation issue in master.

  1. I go BLAST-Jbrowse,
  2. Log in,
  3. Click to enable native tracks
  4. Click to close panel
  5. Make great annotations
  6. Close and go to my next BLAST hit.
  7. Click to go to the browser and it is apollo1 style (mostly) there is the modern organism selector, but no chevron to enable the Apollo2 right-side panel.

Here is the URL: https://myserver.orgnet/apollo/9181426326681843991119596663/jbrowse/index.html?loc=Scaffold66%3A414756..1116791&addTracks=%5B%7B%22label%22%3A%22BLAST%20%20Results%22%2C%22category%22%3A%220.%20Reference%20Assembly%22%2C%22type%22%3A%22WebApollo%2FView%2FTrack%2FDraggableBLASTFeatures%22%2C%22store%22%3A%22url%22%2C%22style%22%3A%7B%22renderClassName%22%3A%22gray-center-10pct%22%2C%22subfeatureClasses%22%3A%7B%22match_part%22%3A%22blast-match_part%22%7D%7D%7D%5D&addStores%3D%7B%22url%22%3A%7B%22type%22%3A%22JBrowse%2FStore%2FSeqFeature%2FGFF3%22%2C%22urlTemplate%22%3A%22https%3A%2F%2Fmyotherserver.orgnet%2Fwebapp%2Fmedia%2Fblast%2Ftask%2F1bfc16f0ffe549619bce4fd12cdf2484%2FAgla_Btl03082013.genome_new_ids.fa.gff%22%7D%7D=&tracks=DNA%2CAnnotations%2CBLAST%20%20Results&highlight=

Version: 2.0.6-SNAPSHOT Grails version: 2.5.5 Groovy version: 2.4.4 JVM version: 1.8.0_112

apollo2 0 6-logged-in-no-apollo2-features

childers commented 7 years ago

Can replicate this on Chrome and Opera. Additionally, I don't have to collapse anything. If I'm logged in and open another link, it takes me to an apollo1 looking interface with no options to go to apollo2.

Could it be that subsequent links are redirecting to the view you removed the Open Annotator Panel and Show Fullscreen buttons from?

nathandunn commented 7 years ago

That is exactly it.

Nathan

On Dec 22, 2016, at 1:49 PM, childers notifications@github.com wrote:

Can replicate this on Chrome and Opera. Additionally, I don't have to collapse anything. If I'm logged in and open another link, it takes me to an apollo1 looking interface with no options to go to apollo2.

Could it be that subsequent links are redirecting to the view you removed the Open Annotator Panel and Show Fullscreen buttons from?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

nathandunn commented 7 years ago
nathandunn commented 7 years ago

In JBrowse Controller, call loadPublicLink, but if there is already a login, but forward to the loadLink call instead with the same data.

I'm not sure if we can open / close the native track div without refreshing (which might be okay). However, we can probably add a button that is always in view to do the same thing.

nathandunn commented 7 years ago

Reopen if still problematic.

childers commented 7 years ago

Ok, just pulled from master, rebuilt and deployed.

When I get redirected from BLAST to Jbrowse everything looks fine. I log in and it redirects me to a blank white screen. Here is the URL post login:

Which is strange in that I' was testing on firefox and not chrome.

UPDATE: When testing in Chrome, it works fine in an incognito window. Shift + reload in firefox to clear cache reloads the page and maintains my logged in state, dropping me to the normal Apollo2 interface.

nathandunn commented 7 years ago

@childers Are you saying that it works now?

childers commented 7 years ago

It seems to work now, yes. I need to test it out a few more times, but it looks like it was caching an older version of the client code that was causing problems.

nathandunn commented 7 years ago

Awesome. Yeah, the caching is a never-ending problem for development ;)

On Jan 3, 2017, at 2:06 PM, childers notifications@github.com wrote:

It seems to work now, yes. I need to test it out a few more times, but it looks like it was caching an older version of the client code that was causing problems.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/GMOD/Apollo/issues/1395#issuecomment-270238664, or mute the thread https://github.com/notifications/unsubscribe-auth/AAt2qlhpHpkgOkrXPe0ET8lLjOSF6Soiks5rOsZMgaJpZM4LUZma.