search

GMOD / Apollo

Genome annotation editor with a Java Server backend and a Javascript client that runs in a web browser as a JBrowse plugin.
http://genomearchitect.readthedocs.io/
Other
128 stars 85 forks source link

Apollo "release" target failing to build #297

Closed nathandunn closed 9 years ago

nathandunn commented 9 years ago

From #296 . . .

Running the "./apollo release" binary ends up deploying the master branch of JBrowse instead of 1.6-release.

This doesn't happen in deploy.

The original checkout is correct, but what gets deployed to the web-app/jbrowse directory is a different version (i.e., master). This was working earlier (this last week), so not sure what has changed.

Please make this a priority. Thanks.

nathandunn commented 9 years ago

FYI @monicacecilia WRT to #296 .

cmdcolin commented 9 years ago

Please elaborate because it's not clear to me what this is about

cmdcolin commented 9 years ago

The code on http://icebox.lbl.gov/WebApollo2/annotator/index is probably not using the master branch (I can check files like http://icebox.lbl.gov/WebApollo2/jbrowse/jbrowse.conf which have not been updated to master branch)

nathandunn commented 9 years ago

It is the master branch:

Some more info:

ndunn:Apollo% find . -name JBrowse* ## I excluded irrelievatn directories ./JBrowse-dev ./jbrowse-download/ ./jbrowse-download/JBrowse-dev/

ndunn:Apollo% find . -name jbrowse ./web-app/jbrowse
ndunn:Apollo%

JBrowse-dev master ./jbrowse-download/ 1.11.6-release ./jbrowse-download/JBrowse-dev 1.11.6-release ./web-app/jbrowse 1.11.6-release

. .. . however, the precompiled code, I am assuming is coming from JBrowse-dev.

This is what Moni and I were seeing:

Nathan

On Apr 19, 2015, at 10:21 AM, Colin Diesh notifications@github.com wrote:

The code on http://icebox.lbl.gov/WebApollo2/annotator/index http://icebox.lbl.gov/WebApollo2/annotator/index is probably not using the master branch (I can check files like http://icebox.lbl.gov/WebApollo2/jbrowse/jbrowse.conf http://icebox.lbl.gov/WebApollo2/jbrowse/jbrowse.conf which have not been updated to master branch)

— Reply to this email directly or view it on GitHub https://github.com/GMOD/Apollo/issues/297#issuecomment-94298419.

screen shot 2015-04-18 at 9 59 03 pm screen shot 2015-04-18 at 10 08 12 pm

cmdcolin commented 9 years ago

Hmm. Ok i will look around. One thing I just did could help though. I fixed a small error with the javascript minimization release target. The javascript in the WA client module had a syntax error

Maybe that will help with this bug (i'll continue looking)

cmdcolin commented 9 years ago

Also, we might want to integrate a command like this into our travis-CI

node src/dojo/dojo.js load=build --require "src/JBrowse/init.js" --profile "plugins/WebApollo/js/WebApollo"

That way it will continuously run those syntax checks on our client code :)

nathandunn commented 9 years ago

@cmdcolin Says that the webapollo plugin code may not have been installed properly.

nathandunn commented 9 years ago

I tested it locally and it seems to work . .

cmdcolin commented 9 years ago

I changed the name of the issue name since i think some of the other things were sort of a side-effect of the main issue (the syntax error). Also now the syntax will be checked via the travis-ci for each git commit so these errors should be easier to catch

nathandunn commented 9 years ago

@cmdcolin Great thanks!

nathandunn commented 9 years ago

Nothing to check for @monicacecilia . . will close.

lfaino commented 9 years ago

Dear All, was this problem fixed?

Luigi

nathandunn commented 9 years ago

@Ifaino Yes. If you have a new issue, please create a new bug or post to the list: "apollo@lists.lbl.gov". Thanks!