GMOD / Apollo

Genome annotation editor with a Java Server backend and a Javascript client that runs in a web browser as a JBrowse plugin.
http://genomearchitect.readthedocs.io/
Other
124 stars 85 forks source link

(4h) replace all "alert" dialogs with something boot-strappy in GWT #489

Closed nathandunn closed 8 years ago

nathandunn commented 9 years ago

I was going to do with for the logout dialog, but I realized that this is everywhere within the jbrowse / apollo-plugin code.

@cmdcolin @enuggetry Let me know if you have any thoughts.

Gwt-land uses its own bootstrap dialog. Would be great to emulate this. Not sure if this is in JBrowse, but doesn't necessarily need to be.

nathandunn commented 8 years ago

I think we can at least do this in a lot of GWT-code pretty easily

nathandunn commented 8 years ago

Nothing to test here really . . .

cmdcolin commented 8 years ago

If you enter invalid user information in the Login then there is a bootbox but there is also some other layer making it impossible to click anything

nathandunn commented 8 years ago

Thanks for reporting. Probably the glass pane . . . I’ll put something else there.

Nathan

On Oct 17, 2015, at 12:17 AM, Colin Diesh notifications@github.com wrote:

If you enter invalid user information in the Login then there is a bootbox but there is also some other layer making it impossible to click anything

— Reply to this email directly or view it on GitHub https://github.com/GMOD/Apollo/issues/489#issuecomment-148892578.

nathandunn commented 8 years ago

To test:

nathandunn commented 8 years ago

You can't really test that everywhere, but let me know if overall they look better or if you have any other changes (or run into any problems).

monicacecilia commented 8 years ago

Uh-oh... this one is still an old style alert...

screen shot 2015-10-26 at 4 43 13 pm

monicacecilia commented 8 years ago

otherwise, the ones I've seen are mostly looking fine. :+1: I'm ok if you want to close and leave the improvement of this one error for 2.0.2

nathandunn commented 8 years ago

I just saw this . . its going to be impossible for you to determine which ones are "dojo" and which ones are GWT / Bootstrap (my bad) . . . so I'll close this one for now and open another one to convert the dojo ones to something else

monicacecilia commented 8 years ago

:+1: