search

GMOD / Apollo

Genome annotation editor with a Java Server backend and a Javascript client that runs in a web browser as a JBrowse plugin.
http://genomearchitect.readthedocs.io/
Other
127 stars 85 forks source link

Add label to History window to identify revert button #769

Closed monicacecilia closed 8 years ago

monicacecilia commented 8 years ago

In the 'History' window, add a label that identifies the function of the 'revert' button. Suggested by @adnguyen999

monicacecilia commented 8 years ago

@deepakunni3 already working on this

monicacecilia commented 8 years ago

Assigned to @nathandunn for review. :bowtie:

monicacecilia commented 8 years ago

One thing not behaving as expected, though.... Sorry, I just caught this back.

When I use the revert button in the 'History' panel: screen shot 2016-03-03 at 4 46 18 pm I expect the bookmark screen shot 2016-03-03 at 4 47 07 pm to shift positions in order to indicate the 'new' current gene model. The image representing the gene model is updated, but the bookmark drawing remains With the version of the gene model that was available when I first pulled up the 'History' panel. -- It should also change right away.

You can close the 'History' panel and open it again to see the new placement of the bookmark. But it should happen right away.

monicacecilia commented 8 years ago

I'm tolerant of punting this down to 2.0.3, given that it is a minor thing - but it should be fixed ASAP after this release.

nathandunn commented 8 years ago

I think that it makes sense.

nathandunn commented 8 years ago

I do think I tried to work on this, but I can't remember if there were some minor issues preventing this. Anyway, I'm sure its doable.

nathandunn commented 8 years ago

@deepakunni3 I think you just need to modify this code:

https://github.com/GMOD/Apollo/blob/master/client/apollo/js/View/Track/AnnotTrack.js#L3410-L3425

You could handle it in the callback, but I think that this would be easier. I think you could just add/remove the iconClass and change the labelText.

nathandunn commented 8 years ago

It could be that we don't use the iconClass at all if that ends up being easier. I think a * or a left-arrow should convey the same meaning. http://www.webstandards.org/learn/reference/charts/entities/symbol_entities/

monicacecilia commented 8 years ago

Great, so clicking on the 'revert' button genomic element back to that state, and the 'bookmark' symbol now moves to the reverted state. This is great! 💃 screen shot 2016-06-02 at 10 53 36 am

However, the original request of adding a label to the button or to the column that reads 'Revert' or explains what the button is for, has not been met. Could we please add the words 'Revert to' at the top of this column?

thanks!

nathandunn commented 8 years ago

I think that "Set" looks better.

screen shot 2016-06-02 at 11 38 31 am screen shot 2016-06-02 at 11 38 14 am

nathandunn commented 8 years ago

@monicacecilia Can you supply some feedback on the verbiage for above?

https://github.com/GMOD/Apollo/issues/769#issuecomment-223383479

Words are hard.

monicacecilia commented 8 years ago

How about just 'Revert'? 'Set' by itself does not convey much meaning in this context.

nathandunn commented 8 years ago

👍

monicacecilia commented 8 years ago

💃