ihh
commented
5 months ago One suggestion I had was to keep everything lower case eg “refseqs” not “refSeqs”, since upper case is generally viewed as a complication in command line UIs.
On Thu, Feb 15, 2024 at 8:59 AM Dario Beraldi @.***> wrote:
Add query commands assemblies, refSeqs, features with basic functionality. There is also some refactoring of the Config and BaseCommand to avoid code duplication.
You can view, comment on, or merge this pull request online at:
https://github.com/GMOD/Apollo3/pull/356 Commit Summary
- 047f940 https://github.com/GMOD/Apollo3/pull/356/commits/047f94034596707f877bb8b236f6f1f8498f6cac Temporary commit - work in progress
- 1c53d26 https://github.com/GMOD/Apollo3/pull/356/commits/1c53d26aeb06862d6cde6847a262e54bbf109b97 Tmp commit: Refactor access
- b9fee60 https://github.com/GMOD/Apollo3/pull/356/commits/b9fee60fdc871db2c47416b938da384d3c211bf9 Add query commands and refactor
File Changes
(13 files https://github.com/GMOD/Apollo3/pull/356/files)
- M packages/apollo-cli/src/Config.ts https://github.com/GMOD/Apollo3/pull/356/files#diff-8ef1949cb8a2fcb8dc2eeffd9118d9485ca8ab496f20783beab98cb7ae020830 (45)
- M packages/apollo-cli/src/baseCommand.ts https://github.com/GMOD/Apollo3/pull/356/files#diff-12e0bb3b6b5fe408a2f36f977e8baa0f8c4fe3772fcad6b484afa5b62b7060a8 (32)
- A packages/apollo-cli/src/commands/assemblies/get.test.ts https://github.com/GMOD/Apollo3/pull/356/files#diff-bc5f99dfe6b5d47c4fa23af7bf71eea4fe8b9b51425fc679fcb86638208bd8f5 (51)
- A packages/apollo-cli/src/commands/assemblies/get.ts https://github.com/GMOD/Apollo3/pull/356/files#diff-d8b8fd1393070b5b374ea096045231479fc4b6ab97419326b33037585ff86b82 (36)
- M packages/apollo-cli/src/commands/config.ts https://github.com/GMOD/Apollo3/pull/356/files#diff-5ee64e83d314e4ffb37f6a0a80d768df13ef718a5ab5c67fbb5716a12f55018f (6)
- A packages/apollo-cli/src/commands/features/get.ts https://github.com/GMOD/Apollo3/pull/356/files#diff-84d4f0ec2f6ceb6bda0c860ab43d576398cbf2823c2a328fd504b994791c013e (82)
- M packages/apollo-cli/src/commands/login.ts https://github.com/GMOD/Apollo3/pull/356/files#diff-7dde295338181efed2c7fd1a3cb2b226e8d342e606c2a9b5eb816ec501cc27fd (8)
- M packages/apollo-cli/src/commands/logout.ts https://github.com/GMOD/Apollo3/pull/356/files#diff-ce03c39138cc6c88917f5efd381acc1c749a8edfc43f1612345839d67c88d17e (4)
- A packages/apollo-cli/src/commands/refSeqs/get.ts https://github.com/GMOD/Apollo3/pull/356/files#diff-7743a3cb2735e9f1148e7f7730a7cbe98986deb0e4546640d37841071ce0440c (22)
- M packages/apollo-cli/src/commands/status.ts https://github.com/GMOD/Apollo3/pull/356/files#diff-ce8c61a14fab8283f9c7ef3d2cde6cceb775f9ea4b8fb520e6c2dda25c5e6f4f (4)
- M packages/apollo-cli/src/utils.ts https://github.com/GMOD/Apollo3/pull/356/files#diff-e3cc89919f2f4bf0fe5f03170f079fb124386e8abb92d8ea2460d0e9325f22b5 (58)
- M packages/apollo-cli/test_data/complete_config.yaml https://github.com/GMOD/Apollo3/pull/356/files#diff-ba0b6550009b25e66e1a2076059f8ae567bed1dcd641bf29a62f27944f664c30 (2)
- A packages/apollo-cli/test_data/incomplete_config.yaml https://github.com/GMOD/Apollo3/pull/356/files#diff-d70c2cb38a8b3f3ece8d09b4ddab835a9ee348d11a7953709681f695305aaec3 (3)
Patch Links:
— Reply to this email directly, view it on GitHub https://github.com/GMOD/Apollo3/pull/356, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAANGYNTLARBSMHLPSJ5UO3YTY5INAVCNFSM6AAAAABDKTWTCWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEZTOMBSGIYDCNY . You are receiving this because you are subscribed to this thread.Message ID: @.***>
garrettjstevens
Add query commands
assemblies,refSeqs,featureswith basic functionality. There is also some refactoring of theConfigandBaseCommandto avoid code duplication.