Open Ferrisx4 opened 2 years ago
This feels like a fairly straight forward addition and would be a small change I believe
I support this change :-) @Ferrisx4 would you like to make a PR for it?
Sure thing @laceysanderson
Hi all, a few questions as it is my first attempt at contributing to Chado -
migrations/
directory in the 1.4 branch, correct? There's also chado/migrations
.
As for the name, would it be something like V1.4.???.010__add_contact_dbxref_table.sql?.Hey @Ferrisx4 so you have been confused by what I just described in issue #130 . I think it needs some clarification. But it's my understanding for now, that you would use something like V1.3.3.011_add_contact_dbxref_table.sql
. Valentin used the _010
suffix in the version for his PR #108 . And you want to do a pull request to the 1.4
branch.
Oh wow, what timing, I hadn't seen #130! Thanks!
Oh, and it seems @laceysanderson just used the _011
suffix in PR #118 so you'll want to go with _012
.
The proposed contact_dbxref table would be used to link contacts from
contact
todbxref
for the purpose of storing values such as the contact's ORCID or Google Scholar ID, or any other external database identifier.A possible implementation of this, following other dbxref tables as a template:
This table was used in a custom plugin on a Tripal site. By utilizing dbxrefs, an individual contact can have multiple entries and their accessions will automatically be available to generate links to their profiles: