search

GMOD / GBrowse

the Generic Genome Browser
http://gmod.org/wiki/GBrowse
Other
49 stars 37 forks source link

Search results return only one feature with the same type, start, and end #45

Closed nathanweeks closed 10 years ago

nathanweeks commented 10 years ago

A colleague and I noticed that a search returning multiple features would not display in the karyotype view more than one feature of a given type when the start & end coordinates were the same. A comment in Bio::Graphics::Browser2::RegionSearch::search_features states that the results should be uniqueified when the name & type are the same, rather than type and start/end locations. I've tried to fix the issue by adding display_name to the mix of uniqueifying criteria.

This issue was first noted here: http://sourceforge.net/p/gmod/mailman/message/26588306/

In response to the concern Scott Cain raised in that thread, I don't think I've broken gbrowse_details---upon cursory inspection, it still seems to function---though to be sure it would be preferable if eyeballs from someone familiar with this section of code looked at it.

scottcain commented 10 years ago

Given that I don't even remember making the comment, I'll pass the buck on this one too.

lstein commented 10 years ago

Thanks for the fix!