search

GMOD / GenomeFeatureComponent

Provides SVG View for Genome Features rendered with the Apollo Track Web Service from JBrowse data React Component
1 stars 4 forks source link

First Pass at different tracks for each type #59

Closed pjhale closed 4 years ago

pjhale commented 4 years ago

In this commit now each of the categories of type (those that have a symbol) now get allocated a track. They are also binned by type so features of different types never bin together. Also if not all types are present the space is not allocated for them.

pjhale commented 4 years ago

Overlap? With what exactly? The labels should have their own space below where the variant tracks are. Could you screenshot what you are talking about... I'm not sure I'm seeing what you are.

nathandunn commented 4 years ago

@pjhale I'll try hard to do a screenshot . . I might have to dit with my phone lol

nathandunn commented 4 years ago

Good:

A49F18B4-2FD2-4E9C-A329-D5DE16C8C68C_1_102_o

Less Good:

F2575E8D-C3B3-45A8-86A9-474831AE9310_1_105_c

If we can't add more space, its still fine, but if we can add more space that would bidea.

nathandunn commented 4 years ago

Screenshots aren't taking my cursor , thus the "shots of my screen"

nathandunn commented 4 years ago

If for some reason my little blip its not fixable, that’s fine. I mostly worry about the case if you have 3 separate tracks lined up, but maybe that’s not a problem.

On Apr 14, 2020, at 2:14 PM, Paul Hale notifications@github.com wrote:

Overlap? With what exactly? The labels should have their own space below where the variant tracks are. Could you screenshot what you are talking about... I'm not sure I'm seeing what you are.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/GMOD/GenomeFeatureComponent/pull/59#issuecomment-613684857, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFXNKW2CQ2HN6MBV3G4F73RMTG3LANCNFSM4MIAI7QQ.

pjhale commented 4 years ago

Ahh okay... I thought it was conflicting with an element on the page. Ill try to push a fix tomorrow either moving the label or adding some extra padding, maybe both.

nathandunn commented 4 years ago

Sounds good

Nathan

On Apr 14, 2020, at 5:53 PM, Paul Hale notifications@github.com wrote:

 Ahh okay... I thought it was conflicting with an element on the page. Ill try to push a fix tomorrow either moving the label or adding some extra padding, maybe both.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

pjhale commented 4 years ago

Ended up just adding extra space... moving the labels just made them feel misaligned. Also fixed legend to show delIns with MNV since thats how they are displayed.

nathandunn commented 4 years ago

That looks a ton better. And thanks for remembering the MNV / delins piece.