Adding Highlight to onClick Event

GMOD / GenomeFeatureComponent

Provides SVG View for Genome Features rendered with the Apollo Track Web Service from JBrowse data React Component

1 stars 4 forks source link

Adding Highlight to onClick Event #65

Closed pjhale closed 4 years ago

pjhale commented 4 years ago

Simple implementation of highlight, could use to be cleaned up a bit but is working.

FYI @nathandunn I don't know if this is truly ready for merge yet... wanted to get something working ASAP.

nathandunn commented 4 years ago

I think it looks great! Yeah, at some point we should refactor, but it works well.

Only suggestion for improvement would be to close it and remove the vertical bar if I click on the same variant again.

pjhale commented 4 years ago

I think this is good to merge now... the only issue I can see someone having is now there is no way (other than a page refresh) to get rid of the click highlight completely. We can always add a button in the popup down the line to do this.

nathandunn commented 4 years ago

looks great and works great!