GMOD / GenomeFeatureComponent

Provides SVG View for Genome Features rendered with the Apollo Track Web Service from JBrowse data React Component
1 stars 4 forks source link

Agr 2367 #70

Closed pjhale closed 4 years ago

pjhale commented 4 years ago

Fixing AGR 2367 and some of 2342.

This pull will center the view around the requested region and display partial features. This will also now correctly display the axis values. Included in this is a correction to transcript labels.

A couple of notes on the fix here thus far. The code will display any part of a feature that is returned within the data range. Right now it simply cuts off the rest of the feature. It will also move the transcript arrows if necessary though these are rendered slightly "out of bounds" within the browser. Also, if a transcript label would render beyond the bounds of the browser it will recenter it within those bounds. On the right side of the browser this is done via the bbox method since its hard to determine how long a box is without actually rendering it. Last note this only applies to the isoform track rendering. Everything here could be moved to the isoform and variant track fairly easily once finalized.

I'm not sure if this is ready for merge... any comments Nathan would be appreciated.