Closed cmdcolin closed 2 years ago
Merging #89 (3f6a580) into master (2e76f0e) will decrease coverage by
0.11%
. The diff coverage is98.59%
.:exclamation: Current head 3f6a580 differs from pull request most recent head 6008300. Consider uploading reports for the commit 6008300 to get more accurate results
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
- Coverage 82.24% 82.13% -0.12%
==========================================
Files 13 13
Lines 1104 1086 -18
Branches 230 225 -5
==========================================
- Hits 908 892 -16
+ Misses 196 194 -2
Impacted Files | Coverage Δ | |
---|---|---|
src/record.ts | 76.96% <83.33%> (-0.16%) |
:arrow_down: |
src/bamFile.ts | 89.38% <100.00%> (-0.43%) |
:arrow_down: |
src/htsget.ts | 92.18% <0.00%> (+3.12%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2e76f0e...6008300. Read the comment docs.
Approx performance gains
deep coverage short reads
ultra long reads 80x coverage
Restores the reloading of chunk caching. It was removed without well documented reason, possibly assuming the the unzipping was a minority of the time or that not storing the unzipped content would reduce memory usage (which may be true) but it is faster to keep the cache as jbrowse repeatedly requests the same blocks for the neighboring block based tracks