search

GMOD / bbi-js

Parser for bigwig and bigbed files
MIT License
8 stars 6 forks source link

Use returned buffer from read() #30

Closed garrettjstevens closed 5 years ago

garrettjstevens commented 5 years ago

Same idea as https://github.com/GMOD/bam-js/pull/42: Use the buffer returned from read() instead of the one that got passed in.

@cmdcolin note this is a PR into your typescripting branch. Not sure what that needs, but it looks like it'll need to get merged before we can release another version since the current master won't build due to TS errors.

cmdcolin commented 5 years ago

I'll see what I can do about the typescripting branch

cmdcolin commented 5 years ago

Am curious what you mean by the current master failing though

garrettjstevens commented 5 years ago

If you check out the current master and run yarn build, it fails due to typescript errors. I added a build step to Travis in this PR so we could catch that in the future.

cmdcolin commented 5 years ago

Build should be fixed on master

cmdcolin commented 5 years ago

The typescripting branch is cool but I wouldn't necessarily wait on it. Maybe rebase this onto master

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (typescripting@837b155). Click here to learn what that means. The diff coverage is 90%.

Impacted file tree graph

@@               Coverage Diff                @@
##             typescripting      #30   +/-   ##
================================================
  Coverage                 ?   79.35%           
================================================
  Files                    ?        6           
  Lines                    ?      465           
  Branches                 ?       87           
================================================
  Hits                     ?      369           
  Misses                   ?       96           
  Partials                 ?        0
Impacted Files Coverage Δ
src/range.ts 16.25% <0%> (ø)
src/blockView.ts 92.66% <100%> (ø)
src/bigbed.ts 98.59% <100%> (ø)
src/bbi.ts 91.4% <87.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 837b155...fbc8a05. Read the comment docs.