search

GMOD / bbi-js

Parser for bigwig and bigbed files
MIT License
8 stars 6 forks source link

Improve typescripting #54

Closed cmdcolin closed 1 year ago

cmdcolin commented 1 year ago

Adds some unicorn lint rules and improves abortable-promise-cache typescripting

codecov[bot] commented 1 year ago

Codecov Report

Merging #54 (29327e5) into master (2699c98) will decrease coverage by 0.19%. The diff coverage is 89.09%.

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   78.03%   77.85%   -0.19%     
==========================================
  Files          10       10              
  Lines         610      605       -5     
  Branches      116      111       -5     
==========================================
- Hits          476      471       -5     
  Misses        121      121              
  Partials       13       13
Impacted Files Coverage Δ
src/range.ts 17.44% <0.00%> (+0.20%) :arrow_up:
src/util.ts 61.29% <50.00%> (ø)
src/bbi.ts 90.47% <94.44%> (-1.13%) :arrow_down:
src/block-view.ts 94.00% <94.44%> (ø)
src/bigbed.ts 98.75% <100.00%> (-0.02%) :arrow_down:
src/bigwig.ts 100.00% <100.00%> (ø)
src/unzip.ts 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

cmdcolin commented 1 year ago

This PR ended up being pretty similar to https://github.com/GMOD/bam-js/pull/96

I made it so that APIs from the PR only accept BaseOpts instead of AbortSignal|BaseOpts so could also be a major version bump