search

GMOD / cram-js

Read CRAM v3 and v2 in node or in the browser
MIT License
18 stars 9 forks source link

Remove stat #131

Open cmdcolin opened 11 months ago

cmdcolin commented 11 months ago

This removes checks for "file out of bounds" to cram-js

While the code is a bit "safer" perhaps with these checks, they require that "stat" works which requires specialized CORS headers to be set. Access to files for example https://ftp.1000genomes.ebi.ac.uk/vol1/ftp/data_collections/HGDP/data/Sindhi/HGDP00171/alignment/HGDP00171.alt_bwamem_GRCh38DH.20181023.Sindhi.cram work with this PR enabled, but not without this PR

Draft PR because tests may be non-passing, but tested in the genome browser

cmdcolin commented 11 months ago

an alternative is making these checks "optional" so they are applied if the stat result is available so you get some partial safety from this