search

GMOD / cram-js

Read CRAM v3 and v2 in node or in the browser
MIT License
18 stars 9 forks source link

Remove usage of `url` node module #134

Closed cmdcolin closed 7 months ago

cmdcolin commented 7 months ago

the end result being that less polyfills are needed. the behavior of 'dynamically switching to use localfile' is something that can instead be solved by user code if they need it

cmdcolin commented 7 months ago

xref https://github.com/GMOD/jbrowse-components/discussions/4296

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.26%. Comparing base (9021a23) to head (c7dae63).

:exclamation: Current head c7dae63 differs from pull request most recent head 814e925. Consider uploading reports for the commit 814e925 to get more accurate results

Files Patch % Lines
src/io/index.ts 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #134 +/- ## ========================================== + Coverage 90.21% 90.26% +0.05% ========================================== Files 39 38 -1 Lines 1962 1952 -10 Branches 395 400 +5 ========================================== - Hits 1770 1762 -8 + Misses 191 176 -15 - Partials 1 14 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.