search

GMOD / docker-apollo

:whale: Apollo 2.X Docker Image
GNU General Public License v3.0
10 stars 12 forks source link

pg user / password is not passed to psql #22

Closed epaule closed 7 years ago

epaule commented 7 years ago

in docker-apollo/launch.sh on master

you probably want: a.) PGPASSWORD=$WEBAPOLLO_DB_PASSWORD passed along b.) a -U $WEBAPOLLO_DB_PASSWORD passed into the options

nathandunn commented 7 years ago

Shoot, would it be possible for you to submit a PR?

If not, I can do it, but I’d rather pull straight off of your working copy.

Thanks,

Nathan

On Oct 9, 2017, at 8:29 AM, Michael Paulini notifications@github.com wrote:

in docker-apollo/launch.sh on master

you probably want: a.) PGPASSWORD=$WEBAPOLLO_DB_PASSWORD passed along b.) a -U $WEBAPOLLO_DB_PASSWORD passed into the options

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GMOD/docker-apollo/issues/22, or mute the thread https://github.com/notifications/unsubscribe-auth/AAt2qvMl1gNeuWRn81ArTdO5S00_5HtHks5sqjvngaJpZM4PyqqM.

epaule commented 7 years ago

Can do. Just need to create a clean branch for the PR. But my hack doesn't fix the logic bit that you most likely wont be able to create the pg user / database as the user itself.

On 10 October 2017 at 00:50, Nathan Dunn notifications@github.com wrote:

Shoot, would it be possible for you to submit a PR?

If not, I can do it, but I’d rather pull straight off of your working copy.

Thanks,

Nathan

On Oct 9, 2017, at 8:29 AM, Michael Paulini notifications@github.com wrote:

in docker-apollo/launch.sh on master

you probably want: a.) PGPASSWORD=$WEBAPOLLO_DB_PASSWORD passed along b.) a -U $WEBAPOLLO_DB_PASSWORD passed into the options

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/GMOD/docker-apollo/issues/22>, or mute the thread < https://github.com/notifications/unsubscribe-auth/ AAt2qvMl1gNeuWRn81ArTdO5S00_5HtHks5sqjvngaJpZM4PyqqM>.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GMOD/docker-apollo/issues/22#issuecomment-335319746, or mute the thread https://github.com/notifications/unsubscribe-auth/AABQK3NinUH_uvNjp5I250t0lFghmHujks5sqrEqgaJpZM4PyqqM .

nathandunn commented 7 years ago

@epaule I can push to your PR to fix anything additional. Thanks.

nathandunn commented 7 years ago

closed by #23