search

GMOD / docker-apollo

:whale: Apollo 2.X Docker Image
GNU General Public License v3.0
10 stars 12 forks source link

fix use of environmental variables #46

Closed nathandunn closed 5 years ago

nathandunn commented 5 years ago

fix #43

nathandunn commented 5 years ago

@MoffMade / @erasche / @abretaud

Can you review when you have a moment.

I updated to tomcat 9, makes Chado optional, and variables are properly getting into the tomcat environment now (I think there was a bug with Tomcat 8.5), and the tomcat gets executed (more docker-like), but I think this is overall better, but let me know as I'm not the expert here.

If you are running in a separate environment, no need to test, but your expertise is always appreciated.

hexylena commented 5 years ago

Looks ok to me? Can't quite tell if it bakes environment variables into build process, but suppose that's OK even if it does it.

nathandunn commented 5 years ago

That's what it looks like, but actually what it is doing is creating a setenv.sh file in the tomcat space that maps . Looking on the interwebs, it looks like you have to set stuff this way otherwise they don't get picked up in the tomcat environment, which is what @MoffMade ran into. I think this was due to a change in tomcat.