GMOD / docker-apollo

:whale: Apollo 2.X Docker Image
GNU General Public License v3.0
10 stars 12 forks source link

GFF3 track not working #47

Closed heshamgibriel closed 5 years ago

heshamgibriel commented 5 years ago

Hello,

I am trying to add a new repeat track using the GFF3 track (attached) and it got successfully loaded. However, I can't see the data as it only shows the loading sign without actual data!

Cheers,

Screenshot from 2019-06-11 09-51-41

nathandunn commented 5 years ago

1 - what does the GFF3 look like (just a few samples) 2 - how did you add it (upload on the track panel, upload in the file menu, or by manually editing trackList.json) 3 - do you see any errors in the javascript console?

heshamgibriel commented 5 years ago

1- plz see gff gff

2-I uploaded it by the upload on the track panel. I uploaded many gffs with this one, but this is the only gff that is not readable!!

3- yeah, I see this error(attached error )

nathandunn commented 5 years ago

Perfect. I'll take a look.

cmdcolin commented 5 years ago

The crash is due to the sequence-region line in your GFF not corresponding as expected

See the gff3 spec https://github.com/The-Sequence-Ontology/Specifications/blob/master/gff3.md

##sequence-region seqid start end
The sequence segment referred to by this file, in the format "seqid start end". This element is optional, but strongly encouraged because it allows parsers to perform bounds checking on features. There may be multiple ##sequence-region directives, each corresponding to one of the reference sequences referred to in the body of the file, however only one ##sequence-region directive may be given for any given seqid. While a ##sequence-region pragma is not required for any or all landmark features when one is given all features on that landmark feature (having that seqid) must be contained within the range defined by that ##sequence-region diretive. An exception to this rule is allowed when a landmark feature is marked with the Is_circular attribute. In that case the features contained on that landmark may extend their coordiantes beyond the boundary as described above.

Also your column 9 is not formatted right I think too, it should use equals signs e.g. Target=...

heshamgibriel commented 5 years ago

I removed this line and formated col 9 as attached, but it's still not working!

test3

cmdcolin commented 5 years ago

@heshamgibriel Is there a new error?

heshamgibriel commented 5 years ago

yes (attached error_new )

nathandunn commented 5 years ago

Is that the error you get when you click on and off repeats?

In this case, I’m not seeing an error in the track or the console.

Could you provide the revised GFF3 for repeats?

Nathan

On Jun 11, 2019, at 10:28 AM, heshamgibriel notifications@github.com wrote:

yes (attached https://user-images.githubusercontent.com/39313063/59293230-aee84d00-8c76-11e9-9587-39554cfab035.png )

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GMOD/docker-apollo/issues/47?email_source=notifications&email_token=AAFXNKRUOE2KED27C2X2ONTPZ7ODNA5CNFSM4HW4BZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXN43XY#issuecomment-500944351, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFXNKQPNNG6AN6EIJUDUGTPZ7ODNANCNFSM4HW4BZVA.

heshamgibriel commented 5 years ago

so this is the one that I used revised_repeats

nathandunn commented 5 years ago

Could you upload a text version of it?

It might be an error in my upload code.

Thanks,

Nathan

On Jun 11, 2019, at 10:37 AM, heshamgibriel notifications@github.com wrote:

so this is the one that I used https://user-images.githubusercontent.com/39313063/59293800-e3a8d400-8c77-11e9-830a-dc3fe115c15e.png — You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GMOD/docker-apollo/issues/47?email_source=notifications&email_token=AAFXNKX2SGCDLGCWSUKIJ4LPZ7PFJA5CNFSM4HW4BZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXN5VPA#issuecomment-500947644, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFXNKSOQYUNML6MNUTKCVDPZ7PFJANCNFSM4HW4BZVA.

heshamgibriel commented 5 years ago

test3.gff.txt

nathandunn commented 5 years ago
cmdcolin commented 5 years ago

@nathandunn is it a jbrowse issue?

nathandunn commented 5 years ago

I don’t know.

My hope is no and that it is an Apollo upload configuration issue.

I need to test that.

On Jun 11, 2019, at 5:04 PM, Colin Diesh notifications@github.com wrote:

@nathandunn https://github.com/nathandunn is it a jbrowse issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GMOD/docker-apollo/issues/47?email_source=notifications&email_token=AAFXNKSFLJYQ7CV5H34Z7Z3P2A4QVA5CNFSM4HW4BZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXO3HWA#issuecomment-501068760, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFXNKQBPWHIMAUU4HBCWG3P2A4QVANCNFSM4HW4BZVA.

cmdcolin commented 5 years ago

I can see from this that --type mRNA is added and the type in his gff is 'similarity' (e.g. they are not gene annotations)

grails-app/services/org/bbop/apollo/TrackService.groovy
744:        def arguments = [fileToExecute.absolutePath,"--gff",inputFile.absolutePath,"--compress","--type","mRNA","--trackLabel",outputName,"--out",trackPath]
nathandunn commented 5 years ago

Exactly. I added it as a GFF3 with no topLevelFeature and it showed up. However, it looked horrible.

I'm going to see what types of inputs make the most sense. Maybe just running the same command with RepeatMasker will be sufficient, and then I can update the UI to reflect that and limit these types of features to NCList only. Conversely, it could simply automatically scan the file to check and query.

cmdcolin commented 5 years ago

I think you should consider just removing the --type mRNA if you are using jbrowse 1.16.4 or greater. JBrowse 1.16.4 introduced inferHTMLSubfeatures by @abretaud and this allows multiple transcripts to be created from a single gene parent feature

See release notes https://github.com/GMOD/jbrowse/blob/master/release-notes.md#release-1164-----2019-04-10-165802-utc

1.16.5 will be released soon also and contains some more fixes related to using this with NeatFeatures I believe that @abretaud also made

nathandunn commented 5 years ago

@cmdcolin / @abretraud this is awesome

For this, I think you are correct, just removing the --type works (and we are using whatever is on dev until 1.16.5 is released).

I'll add an option for non-transcript data that will accompany the upload. Will try to get that out this week and update the docker image here.

nathandunn commented 5 years ago

will be fixed by https://github.com/GMOD/Apollo/issues/2181

nathandunn commented 5 years ago

Noted, I was able to get it working by dropping the --type command as @cmdcolin suggested. Now I just need to automate it:

image

  ./bin/flatfile-to-json.pl --gff ./test_convert.gff3 --trackLabel RepeatTest --out /opt/apollo/human_test
nathandunn commented 5 years ago

@heshamgibriel This should work now. As soon as the docker finishes building I would do a docker pull and retry it:

https://quay.io/repository/gmod/docker-apollo?tab=builds