GMOD / jbrowse-components

Source code for JBrowse 2, a modern React-based genome browser
https://jbrowse.org/jb2
Apache License 2.0
207 stars 62 forks source link

Additional Unwanted Scrolling in Safari #1388

Closed peterkxie closed 3 years ago

peterkxie commented 3 years ago

Found this during pairing with @elliothershberg while testing the scrolling fix of #1360

Scrolling inside a track is fixed, but scrolling outside still does the unwanted behavior of going back or forward

Back action about to be triggered: image

Forward action about to be triggered: image

cmdcolin commented 3 years ago

It is weird because we have overscroll-behavior: none on the element of index.html. I thought this was an overscroll behavior

cmdcolin commented 3 years ago

I think linear-genome-view plugin does it's best to handle this with event.preventDefault but any other behavior should be in jbrowse-web relating to overscroll or something similar

cmdcolin commented 3 years ago

could try overscroll-behavior-x: contain;

or even

overscroll-behavior: contain

instead of overscroll-behavior: none? ref https://stackoverflow.com/a/60385432/2129219

peterkxie commented 3 years ago

I've tried the following and failed

overscroll-behavior-x: none overscroll-behavior-x: contain overscroll-behavior: contain

peterkxie commented 3 years ago

here's what it looks like in my safari inspect element, maybe something is overriding it?

image

edit: error is unsupported property name, that's probably the issue

peterkxie commented 3 years ago

https://bugs.webkit.org/show_bug.cgi?id=176454

cmdcolin commented 3 years ago

https://tenor.com/view/ffs-baby-really-oh-god-just-stop-gif-12739180

cmdcolin commented 3 years ago

come on safari team

cmdcolin commented 3 years ago

On some level, this is the operating system behavior that they designed. Do we really see this particular behavior as problematic?

peterkxie commented 3 years ago

imo I think it's not as big of a deal as the track container scroll that's fixed. I think its less likely that people try to scroll horizontally on the main page outside of a container since evreything is in view already