GMOD / jbrowse-components

Source code for JBrowse 2, a modern React-based genome browser
https://jbrowse.org/jb2
Apache License 2.0
206 stars 62 forks source link

text search core system #1830

Closed rbuels closed 3 years ago

rbuels commented 3 years ago

Implement the core code for JB2 text searching.

Requirements:

Implementation sketch:

garrettjstevens commented 3 years ago

If the textSearch manager volatile is a plain TS class, will it be able to observe new tracks or sessions being created? e.g. if a user adds a session track that has a track-level name index, it would be nice if the textSearch manager could observer that and automatically add the index. Same idea if a session track is deleted.

What if the text search manager was a MST model so it could take advantage of observing the tree?

rbuels commented 3 years ago

Does it need to observe the tree? I was thinking it could just examine all the configurations/tracks when a search is launched to find the relevant indexes, which would be stateless

garrettjstevens commented 3 years ago

Ok, that makes sense. Maybe it should keep an LRU cache of instantiated adapters, though?

demis001 commented 3 years ago

What is the status the textSearch option (generate names)? Is it possible to search a gene name in search area? Without it , I have to stick to the old jbrowse 1.16

cmdcolin commented 3 years ago

@demis001 being worked on as we speak :)

it may be that if you need stability and features you can use jbrowse 1 for now but jbrowse 2 is fast evolving, and text search, gwas plugin, etc. will hopefully become ready soon (xref https://github.com/cmdcolin/jbrowse-plugin-gwas/issues/1)