GMOD / jbrowse-components

Source code for JBrowse 2, a modern React-based genome browser
https://jbrowse.org/jb2
Apache License 2.0
206 stars 62 forks source link

Dependency rescripts archived #2581

Closed cmdcolin closed 2 years ago

cmdcolin commented 2 years ago

This could be a dependency that is worth considering moving to a different platform in our codebase

https://github.com/harrysolovay/rescripts/

It is marked as archived now so no further development may be expected to happen. it also shows up in a yarn audit due to dependency on outdated react-dev-utils->immer

cmdcolin commented 2 years ago

not the most urgent thing but something to be aware of

cmdcolin commented 2 years ago

one concept could be switching to webpack 5. it actually has a native webworker support. I tried testing it out (changing jbrowse-web to run react-scripts on v5 instead of rescripts on v4) and it seemed to have trouble loading typescript files from our plugins and core but might be something fixable

see https://webpack.js.org/guides/web-workers/#syntax

the file referred to by new Worker("./file.js") actually gets webpack bundling applied

cmdcolin commented 2 years ago

fixed by #2646