GMOD / jbrowse-components

Source code for JBrowse 2, a modern React-based genome browser
https://jbrowse.org/jb2
Apache License 2.0
206 stars 62 forks source link

Hi-C display doesn't change in response to horizontally flipping #3460

Closed cmdcolin closed 1 year ago

cmdcolin commented 1 year ago

no logic tries to address this

KousikRoy-EC commented 1 year ago

Hey can i work on this bug?

cmdcolin commented 1 year ago

@KousikRoy-EC if you'd like. If you're not familiar with the context, the basic idea is that we have the concept of "flipping" the view so things are displayed in reverse coordinates, but this requires manual code to accommodate this in many cases. In our case, the "hi-c" view does not work

you can see this here https://jbrowse.org/code/jb2/v2.4.0/?config=test_data%2Fconfig_demo.json&session=share-VHqsFgdMWt&password=uktxa

that has a hi-c track open

you can then go to the hamburger menu for the view, clip "Horizontally flip" but it has no effect. to fix, you would go into the HicRenderer and add code to flip the view when region.reversed is true

when you run yarn start in the products/jbrowse-web, directory it will start on localhost:3000 and you can open up the link to get the same view of your local dev environment, and the page should auto-reload when you edit e.g. HicRenderer.tsx after that http://localhost:3000/?config=test_data%2Fconfig_demo.json&session=share-VHqsFgdMWt&password=uktxa

cmdcolin commented 1 year ago

note: it is not required to make code contributions before applying to our GSOC if that is what you are aiming at, but if you are keen on it, won't stop ya :)

studentshivang commented 1 year ago

Hello @cmdcolin, I am keen on applying for GSOC 2023. In order, to make some contributions, I have set up the environment as well (to the extent shown in the attached picture ). Could you please point me in the direction, that enables me to write a successful project proposal for "JBrowse 2 Plugins synteny formats". I'd be really grateful for pointers to some exposure to be able to write a meaningful project proposal,(even if I am unable to contribute before the application deadline). I pledge full-time commitment and resourcefulness during the Summer of Code.

Screenshot (5721)

studentshivang commented 1 year ago

Hey Colin, I have reproduced this issue in the local environment. Also, I have implemented one of the possible solutions. I'd like you to have a glance at my progress. Does it seem to be the correct solution? Original original Flipped flipped

cmdcolin commented 1 year ago

@studentshivang you're likely in the right code area but that doesn't look quite right. it should look essentially like you flipped it horizontally/mirror-wise in a image editor

studentshivang commented 1 year ago

I wanted to express my gratitude for your time and support today. I'll try to come up with a better solution.

studentshivang commented 1 year ago

I'll also try to learn background about genomics, bioinformatics, typescript, mobx-state-tree, etc. Actually, I want to hit the track running . I have applied for the "JBrowse 2 Plugins synteny formats" project in GSOC 23.I hope I am going in the right direction.

studentshivang commented 1 year ago

Update: Issue Solved finally_flipped

studentshivang commented 1 year ago

Please review! I'll be checking out the documentation for merging the changes. Hoping to push it soon!

cmdcolin commented 1 year ago

fixed by @studentshivang thanks again

studentshivang commented 1 year ago

My pleasure @cmdcolin , and thank you for your precious help and time!