GMOD / jbrowse-components

Source code for JBrowse 2, a modern React-based genome browser
https://jbrowse.org/jb2
Apache License 2.0
202 stars 61 forks source link

Drawer widget for opening new view #398

Closed cmdcolin closed 4 years ago

cmdcolin commented 5 years ago

This is similar to the devtool for adding a new lgv, but could also involve selecting a different assembly

rbuels commented 5 years ago
cmdcolin commented 5 years ago

I want to make stuff like this:

select whether you want to tie it to an assembly or specify a list of displayedRegions displayedRegions could just be a text box with locstrings one per line maybe

As advanced options

The defaults should be clear

Also I want to add "search functionality".

I think there is some overlap between the proposed concept here and searching/navigating to a user entered locstring

cmdcolin commented 5 years ago

Let me phrase a weird question. Why do we want this feature to open up arbitrary linear genome views below another linear genome view. There are hypotheticals that I can think of, but in the end, I often say to myself that things like synteny need a specialized view, not just two stacked LGV. I guess this function could be useful in some scenarios but it just seems like one of those things that is sort of a little ambiguous for biological use cases

cmdcolin commented 5 years ago

Maybe I am misimagining the purpose. I understand that perhaps we have this whole idea of starting from scratch, or opening a different type of view e.g. circos instead of a linear view.

I'd still like a little bit of user story but maybe this can be delivered as is

garrettjstevens commented 5 years ago

I think the best user story I can think of for now is starting from scratch, like you mentioned. For example, the user will soon be able to create a new session from scratch in the UI. Let's say they want to focus on a particular gene, so they open a new session that doesn't have a view, and then add an LGV that has a region of just that gene.

cmdcolin commented 4 years ago

I think this has been superceded by ImportForm state as implemented by each view type