Closed cmdcolin closed 4 years ago
Could maybe just have the selection be the feature ID
Also remove anything under blockState from the session, cause that will get repopulated
Also look at having drawer widget stuff (e.g. featureData) be volatile so it doesn't show up in the snapshot.
If a feature is in the URL bar like a long read or a gene with a bunch of transcripts, you can easily get URL that is 500kb long pre-gzip and repeatedly being gzipped to get to 20kb and that causes large delays in the main thread (sometimes taking 8 seconds to run gzip blocking the main thread)
So as noted above making that volatile would be good...would need to figure out what to do about the drawer on reload...possibly waiting for the feature data to load from the track? Maybe local storage and then fallback to loading from track?
Reducing the amount of information in the session doesn't really have a clear definition of done. I kind of think we should close this issue.
On Sun, Dec 29, 2019 at 9:53 PM Colin Diesh notifications@github.com wrote:
If a feature is in the URL bar like a long read or a gene with a bunch of transcripts, you can easily get URL that is 500kb long pre-gzip and repeatedly being gzipped to get to 20kb and that causes large delays in the main thread (sometimes taking 8 seconds to run gzip blocking the main thread)
[image: Screen Shot 2019-12-29 at 9 36 38 PM] https://user-images.githubusercontent.com/6511937/71566406-526b4480-2a85-11ea-97ce-e35b5d06f9a6.png
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GMOD/jbrowse-components/issues/432?email_source=notifications&email_token=AAASAFJIQMCNPCWDWIG4VTLQ3FPCVA5CNFSM4IIJ6H72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZOX5I#issuecomment-569568245, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASAFMMMW43ZJ5ARGZPLMLQ3FPCVANCNFSM4IIJ6H7Q .
Ok, I think my concern of feature data in the URL is probably the most actionable since this can grow to a large size easily if we want to make a new issue for that in particular
Current state of session if it is to be encoded in the URL would benefit from being reduced in size
The menus seem like configuration The individual state of all drawers are maybe something that can be reduced The block states on the view can be removed I think as volatile, I think that this was discussed at one point The alignment feature details are somewhat debatable because if we want to refresh on a feature, you have to re-find the feature in a feature query, but you can easily imagine if you sent a long read feature over a link it would be too long