GMOD / jbrowse-components

Source code for JBrowse 2, a modern React-based genome browser
https://jbrowse.org/jb2
Apache License 2.0
205 stars 61 forks source link

Remove concept of adapterId from FromConfigAdapters #4491

Closed cmdcolin closed 1 month ago

cmdcolin commented 2 months ago

Note: this PR might be more trouble than it is worth for small change

the FromConfigAdapter's are the only adapters that use a concept of adapterId. the usage is not really actually to supply an ID but to prevent the snapshot from collapsing to an empty object (because config objets with default values, in this case, empty array of features, are eliminated at snapshot time) if a fromconfigadapter with no features is supplied. This "no feature" is used in a couple tests.

We can fix that by

this PR was made because the random ID of fromconfigadapters was tricky to snapshot properly (since you'd need to mock the id generator), but i just removed the snapshot tests instead

cmdcolin commented 1 month ago

closed as a historical note perhaps