GMOD / jbrowse-components

Source code for JBrowse 2, a modern React-based genome browser
https://jbrowse.org/jb2
Apache License 2.0
205 stars 61 forks source link

Add new eslint rules (no-unnecessary-condition, no-unused-expressions, etc) and tsconfig noUncheckedIndexedAccess #4513

Closed cmdcolin closed 1 month ago

cmdcolin commented 1 month ago

This PR adds some upgrades to linting

specifically

cmdcolin commented 1 month ago

also adds eslint rule @typescript-eslint/no-unused-expressions which caught an error in coverage calculations in the methylation mode

diff here shows that there was a "unused expression" where a mutation was intended

image