GMOD / jbrowse-components

Source code for JBrowse 2, a modern React-based genome browser
https://jbrowse.org/jb2
Apache License 2.0
205 stars 61 forks source link

Fix windows desktop build certificate causing failed upgrades #4568

Closed cmdcolin closed 1 week ago

cmdcolin commented 1 week ago

Was noticed that upgrades on windows fail, and that it is probably being signed with an out of date certificate

Need to review how to sign it properly. It might involve creating a new certificate because i'm not sure if we have the original "private key"

May also want to fill out form with microsoft attesting ownership over the app as e.g. edge browser produces warnings for people trying to install it

cmdcolin commented 1 week ago

currently fails to upgrade with a message like this

cmdcolin commented 1 week ago

Untitled

cmdcolin commented 1 week ago

fixed in v2.15.3

cmdcolin commented 1 week ago

see https://github.com/GMOD/jbrowse-components/pull/4571

there is also a private google doc on the process https://docs.google.com/document/d/1Rwok080ri4OGDkyqLGFQqqeXGOkBDo_GxqVuNq5IDAs/edit?usp=drive_link