search

GMOD / jbrowse-components

Source code for JBrowse 2, a modern React-based genome browser
https://jbrowse.org/jb2
Apache License 2.0
205 stars 61 forks source link

Fix code signing on the windows for jbrowse desktop #4571

Closed cmdcolin closed 1 week ago

cmdcolin commented 1 week ago

this is an attempt to get our SSL code signing back into action for our windows app

it had been apparently broken for awhile i believe our certificate was expired since mid-2023, and even attempting to fix it would not work because at that same time in mid-2023 they disabled the method we were using (downloading the p12/pfx file to the WIN_CSC_LINK env variable)

this PR's new solution closely follows https://github.com/electron-userland/electron-builder/issues/6158

cmdcolin commented 1 week ago

note that if we sign a ton of stuff, it might incur a cost but i think we get 20 free ones per month https://www.ssl.com/guide/esigner-pricing-for-code-signing/

each version release i think runs maybe 4 or so signings (multiple exe files are signed in the installer distribution)

cmdcolin commented 1 week ago

"free" meaning...paid with our subscription...

cmdcolin commented 1 week ago

I created a google drive doc with some screenshots documenting my experience with this, it is private to our shared drive https://docs.google.com/document/d/1Rwok080ri4OGDkyqLGFQqqeXGOkBDo_GxqVuNq5IDAs/edit?usp=sharing