Closed cmdcolin closed 1 week ago
this PR also proposes putting all the trix indexes in the appdata folder, with foldername based on +Date.now() timestamp
previously, the trix index folder was colocated with the "session file" location.
i think the old behavior is hazardous and could lead to permission denied errors, annoyances with files being created, and even collisions with previous sessions. the downside is one might have more trouble 'finding' the trix files but there is not really a system for e.g. converting a desktop session to a web session (with folder-relative files) in previous versions, so i think there is no 'change in expectation' from this new behavior.
also, for the record, the above typescript-not-catching-this error is quite surprising. i cannot reproduce it in the typescript playground
random follow up: the explanation of why it didn't catch these issues was because all those params that were being passed wrong were optional args
The name indexing was producing errors on desktop in a way that was actually related to the typescript types not catching an error
there was a argument like this
however, many the parameter names had been renamed (outLocation->outDir, exclude->featureTypesToExclude, attributes->attributesToIndex) at some point and it was not catching that this was an error
however, changing the code to
this instantly produces the typescript errors about providing keys that the function does not want, e.g. it does not want the outLocation, it does not want the exclude, etc.
this is a good hint to audit and purge of any type of 'pre-declare the argument separately from the function call' usages in the codebase
fixes #4570