GMOD / jbrowse-components

Source code for JBrowse 2, a modern React-based genome browser
https://jbrowse.org/jb2
Apache License 2.0
205 stars 61 forks source link

HiC track regression? ReferenceError buffer not defined in 2.15.3? #4583

Closed fubar2 closed 1 week ago

fubar2 commented 1 week ago

Describe the bug 2.15.0 works, but a simple test with a HiC track fails in 2.15.3 with image

To Reproduce

jbrowse create jb2.15.3 -t v2.15.3 
cd jb2.15.3/
jbrowse add-assembly --load symlink ../hg19.fa 
jbrowse add-track --load symlink ../GSE63525_HMEC_combined.hic 
cd ..
jbrowse create jb2.15.0 -t v2.15.0 
cd jb2.15.0/
jbrowse add-assembly --load symlink ../hg19.fa 
jbrowse add-track --load symlink ../GSE63525_HMEC_combined.hic 

Expected behavior With 2.15.0:

image

Screenshots

Version: 2.15.3 vs 2.15.0

cmdcolin commented 1 week ago

thanks so much for reporting this. I can confirm, there were some changes to the build to try to avoid the use of nodejs polyfills and this was a casualty....fix in #4584

cmdcolin commented 1 week ago

went ahead an cut a release to fix this in v2.15.4!

fubar2 commented 1 week ago

Thanks @cmdcolin - that fixed it - thank you very much for the quick fix!