search

GMOD / jbrowse-components

Source code for JBrowse 2, a modern React-based genome browser
https://jbrowse.org/jb2
Apache License 2.0
208 stars 62 forks source link

Package a monospace font #808

Open garrettjstevens opened 4 years ago

garrettjstevens commented 4 years ago

Currently we package the Roboto font so that JBrowse users on any platform will have a consistent experience (Roboto was chosen because it is the suggested font for Material-UI).

We don't package a monospace font, though, and rely on the user's system fonts (or generic font fallbacks), meaning things like the callback editors and pileup renderer may vary depending on the user's system.

I propose we package a monospace font so that users have a consistent experience. I suggest the Roboto Mono font, for consistency with the font we already have.

Biggest downside I can see is increasing our bundle size a bit.

rbuels commented 4 years ago

I assume this is prompted right now by the recent test failures on Mac v Linux?

On Wed, Jan 29, 2020 at 10:47 AM Garrett Stevens notifications@github.com wrote:

Currently we package the Roboto font so that JBrowse users on any platform will have a consistent experience (Roboto was chosen because it is the suggested font for Material-UI https://material-ui.com/getting-started/installation/#roboto-font).

We don't package a monospace font, though, and rely on the user's system fonts (or generic font fallbacks), meaning things like the callback editors and pileup renderer may vary depending on the user's system.

I propose we package a monospace font so that users have a consistent experience. I suggest the Roboto Mono https://fonts.google.com/specimen/Roboto+Mono font, for consistency with the font we already have.

Biggest downside I can see is increasing our bundle size a bit.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GMOD/jbrowse-components/issues/808?email_source=notifications&email_token=AAASAFKMQ7YZJTIALJ3GLLDRAHFK5A5CNFSM4KNJUN62YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IJT36EA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASAFJHS37JV3NVQWTHZZTRAHFK5ANCNFSM4KNJUN6Q .

garrettjstevens commented 4 years ago

Yeah, that's what made me think of it and I figured I'd put it in an issue before I forgot.